[201_95] Disable command mode autocomplete suggestions in macro editor#2953
Merged
wumoin merged 8 commits intoMoganLab:mainfrom Mar 11, 2026
Conversation
Contributor
|
What is needed is to disable the entire |
Contributor
Author
|
Thank you for the clarification @wumoin! I had asked about this in comments as well as in discord but didn't receive any response so just went with this approach. I'll update the PR asap. |
…acro editor, updated developer document devel/201_94.md
Contributor
Author
|
Hello @wumoin, I have refactored the logic and also updated the developer document as well as the PR body. Please review when you have time. |
wumoin
requested changes
Mar 10, 2026
wumoin
reviewed
Mar 10, 2026
wumoin
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2873
In the macro editor, the autocomplete suggestions in command mode
⟨\⟩should be disabled.Summary
Disabled the autocomplete popup suggestions in the macro editor while keeping the
\hybrid command mode functional.Issue Found
When editing macros in the macro editor, typing
\would trigger the command mode⟨\⟩with a popup of autocomplete suggestions.Changes
Modified
src/Edit/Interface/edit_source.cpp:How to test
\key and begin typing.⟨\⟩bracketed tag (hybrid command mode) appears correctly.\key triggers the hybrid command mode completely, and autocomplete functions as normal.\key triggers the hybrid command mode completely, and autocomplete functions as normal.disable_auto_complete_suggestions.mp4